[PATCH] Teach geom_label to recognise gpt labels and uuids

Marius Nünnerich marius at nuenneri.ch
Thu Oct 23 15:18:48 UTC 2008


On Thu, Oct 23, 2008 at 2:01 PM, Marius Nünnerich <marius at nuenneri.ch> wrote:
> On Thu, Oct 23, 2008 at 1:41 PM, Ivan Voras <ivoras at freebsd.org> wrote:
>> Marius Nünnerich wrote:
>>> Hi all,
>>>
>>> I wrote the following patch for geom_label:
>>> http://nuenneri.ch/freebsd/geom_label.patch
>>>
>>> What do you think about it? I would love to hear about some tests.
>>
>> Do you think it's wise to have two separate directories: /dev/gpt and
>> /dev/gpt_uuid? I don't think anyone will mistake the UUID from the label
>> if it's in the same directory. Also, if I remember correctly how GPT
>> works, UUID is always present but the label is optional?
>
> The label can only be 18 characters long and a uuid is always longer
> than that, so that shouldn't be a problem. Actually it's just an
> implementation detail because I couldn't add two /dev entries in one
> taste. I will think about how I could create both entries in one
> directory (if the label is set).

Ok, I updated the patch. It's now just /dev/gpt. I think I'll collapse
the two files into one.

Thanks for your feedback so far.


More information about the freebsd-geom mailing list