[patch] geom_vinum platform fixes
lulf at stud.ntnu.no
lulf at stud.ntnu.no
Sat Mar 15 08:23:21 UTC 2008
Siterer "Rick C. Petty" <rick-freebsd at kiwi-computer.com>:
> On Thu, Mar 13, 2008 at 03:35:51PM +0100, lulf at stud.ntnu.no wrote:
>>
>> I've spent a _lot_ of time fixing gvinum, so your previous statements
>> saying noone is fixing gvinum really is wrong :)
>
SNIP
>> I'm sorry this is taking so
>> long, but there has been much time invested in 7.0 before gvinum. I'm
>> also in Japan for another two weeks, so I won't be able to continue a
>> discussion on this right now.
>>
>> But I agree with your changes, and I'll review and integrate your changes
>> to the new code base ASAP, but this will probably not go in until the
>> new gvinum
>> codebase iscommitted, since that will probably happen before 7.1/6.4 anyway
>
> I'm not sure I want to wait that long. My changes should not conflict with
> yours (and if they do, the overlap would be minimal). I don't see why the
> world should wait until 7.1 to see this fixed. Right now, people cannot
> migrate vinum partitions between i386 and amd64. These people don't need
> all your improvements for that. Besides, my small patch introduces little
> to no instability to geom_vinum and fixes a key piece of broken code.
> Compared to your larger commit, I would think people would prefer to see my
> patch committed immediately and your work to be integrated when you have
> time to test and commit it.
>
Hmm, yes. I didnt look very detailed at the patch so I was not sure if
it would conflict or not.
> That being said and since there have been no objections to my suggestions
> (and Ulf agrees with my changes), is a committer willing to review my
> patch? le@ ? Mr. Lehey?
>
or lulf@ :)
I can commit it after Ive reviewed it unless someone else volunteers
before Icome back from Japan (The 25th of march).
> -- Rick C. Petty
>
>
--
Ulf Lilleengen
More information about the freebsd-geom
mailing list