Can't reattach gbde slice [testing]

[Poul-Henning Kamp]

In message <20040915031733.GA17432 at afields.ca>, Allan Fields writes:
>On Sat, Sep 11, 2004 at 07:59:07PM +0200, Poul-Henning Kamp wrote:
>> can you try the two fixes I just committed to -current ?
>
>Yes, seems to solve problems attaching in this test case.
>I've tried to break things again: so far seems fine, but
>haven't done anything exhaustive.
>
>Is it necessary after patching to rebuild number_of_keys=1 volumes
>that haven't had key sector problems yet?

I would do it to be on the safe side if I were you.  If it is very
cumbersome, it would be possible to tell from the four keysector
locations and the disk-size if there is any danger: basically if
any of the "unused" locations address modulus 2^32 are inside the
size of the disk, then the volume is at risk. 

>Will patches be included in upcoming 5.3-release?  Otherwise
>notification in errata would help, just in case people setup such
>a device.

yes.

>Those with existing such volumes should now dump the filesystem
>and apply patches since they might otherwise loose data w/ existing
>gbde device and an unpatched kernel.

yes.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.