GEOM_VOL panics when audio CD is present
Poul-Henning Kamp
phk at phk.freebsd.dk
Thu Dec 30 11:55:40 PST 2004
In message <xzpoegbvact.fsf at dwp.des.no>, =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=
writes:
>"Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
>> I think the right check is to make sure the sectorsize is a power
>> of two && > DEV_BSIZE.
>
>Not good enough. The panic will still be triggered by providers with
>a sector size larger than 8192 (which is the smallest non-zero offset
>g_vol_ffs_taste() tries to use). The fact that no such devices exist
>today does not mean they won't exist at some point in the not-so-
>distant future.
You're right, we need to check for that too.
They could exist with gbde btw.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
More information about the freebsd-geom
mailing list