[PATCH] mail/thunderbird: crash with nss_ldap

[Geoffroy Desvernay]

>Submitter-Id:	current-users
>Originator:	Geoffroy Desvernay
>Organization:	Ecole Centrale de Marseille
>Confidential:	no 
>Synopsis:	[PATCH] mail/thunderbird: crash with nss_ldap
>Severity:	non-critical
>Priority:	medium
>Category:	ports 
>Class:		sw-bug
>Release:	FreeBSD 9.0-RELEASE amd64
>Environment:
System: FreeBSD dgeo.sysadm.ec-m.fr 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Sun Jan 15 17:00:54 CET 2012
>Description:
Crash 'signal 11' instead of launching thunderbird if using an LDAP (via nss_ldap) account.
backtrace ends in ldap_ functions.

Making some research about this sig11 crash made me find that this port seems to be missing 
CFLAGS+= -DLDAP_DEPRECATED
(at least works for me®)

It seems that this flag has to be set with openldap > 2.3, it should be the case in any freebsd install now (but freebsd with anciens ports of course)

I'm not sure if the port should include 'USE_OPENLDAP' or CFLAG or a patch ?

This (old) gnome bug seems to indicate that it should be done in the port: https://bugzilla.gnome.org/show_bug.cgi?id=456276
(already referenced in 2007: http://freebsd.monkey.org/freebsd-gnome/200707/msg00104.html)

googling for "thunderbird ldap crash nss_ldap" indicates that all *X systems using thunderbird seems to have this same problem.
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/507089
http://forums.opensuse.org/english/get-technical-help-here/applications/429617-thunderbird-3-crashes-wit-segmentation-fault-due-ldap.html


padl's guys says the bug id thunderbird's: http://bugzilla.padl.com/show_bug.cgi?id=203

HTH...

Port maintainer (gecko at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
Install current thunderbird port on a system using nss_ldap, then launch thunderbird with an LDAP account.

>Fix:
Add CFLAGS+= -DLDAP_DEPRECATED
--- thunderbird-9.0.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/mail/thunderbird.orig/Makefile /usr/ports/mail/thunderbird/Makefile
--- /usr/ports/mail/thunderbird.orig/Makefile	2011-12-22 08:17:59.000000000 +0100
+++ /usr/ports/mail/thunderbird/Makefile	2012-01-16 15:04:38.000000000 +0100
@@ -72,6 +72,8 @@
 .endif
 .endif
 
+CFLAGS+=	-DLDAP_DEPRECATED
+
 .if ${HAVE_GNOME:Mlibgnomeui}!=""
 USE_GNOME+=	libgnomeui
 MOZ_OPTIONS+=	--enable-gnomeui
--- thunderbird-9.0.patch ends here ---