firefox3 under powerpc not building

[Joe Marcus Clarke]

On Mon, 2009-08-10 at 21:55 +0200, Andreas Tobler wrote:
> Hi again,
> 
> replying to myself.
> 
> 
> Andreas Tobler wrote:
> 
> > I can not build firefox3 (3.0.13 and up) under FreeBSD -CURRENT. As far 
> > as I tracked down it is an issue in the firefox sources itself.
> > 
> > The last working build I had was 3.0.10.
> > 
> > Here in this area it breaks:
> > 
> > http://mxr.mozilla.org/mozilla1.9.1/diff?file=/security/nss/lib/freebl/Makefile&diffvar=mozilla1.8.0
> > 
> > The below snippet does somehow not work.
> > -----
> > # some code wants _X86_ defined for intel CPUs.
> > # coreconf does this for windows, but not for Linux, FreeBSD, etc.
> > ifeq (,$(filter-out x86 x86_64,$(CPU_ARCH)))
> > ifneq (,$(filter-out WIN%,$(OS_TARGET)))
> >          DEFINES += -D_X86_
> > endif
> > endif
> > -----
> 
> It does not work on powerpc since the CPU_ARCH is set to x86 in 
> security/coreconf/FreeBSD.mk, gah!
> 
> > On powerpc I get the -D_X86_ passed to the compile options, very bad. 
> > But I do not understand why. Might be that the first filter-out does not 
> > work as expected?
> > 
> > I compared with an x86 build and with an x86_64 build. On the x86 it 
> > works as expected. But also under der x86_64 it does not do what I 
> > expect. Under x86_64 I'd expect the -D_X86_ in the compile options, right?
> 
> The x86_64 case is also clear now, the CPU_ARCH is set to amd64, so the 
> -D_X86_ is not set. We might need a patch to 
> security/nss/lib/freebl/Makefile which also includes the amd64 to the 
> first filter-out above? Like this one:

Thanks for these patches.  Can you resend them as attachments (or post
them) so they can be easily extracted?

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gecko/attachments/20090815/5c86ce6f/attachment.pgp