zfs_rename: another zfs+vfs deadlock

[Konstantin Belousov]

On Fri, Jul 19, 2013 at 01:21:19PM +0300, Andriy Gapon wrote:
> Also, I noticed that ufs_rename() checks for cross-device rename.  Should all
> filesystems do that or should that check belong to VFS layer (if not already
> done there)?

In principle yes, this sounds right.

The only concern I see is layered filesystems like nullfs interaction
with filesystems below the bypass.  In other words, if any bypass
provided the aggregation, this should be checked at the bypass
layer too, in addition to the kern_renameat().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20130719/275b2ac8/attachment.sig>