Compatibility options for mount(8)

Jeremy Chadwick jdc at koitsu.org
Tue Jul 9 15:02:21 UTC 2013


On Tue, Jul 09, 2013 at 04:47:46PM +0200, Robert Millan wrote:
> > 2. Please use strncmp().  I know other parts of the same code use strcmp()
> > and those should really be improved at some other time, but while you're
> > already there you might as well use strncmp() (you'll see others have
> > done the same), i.e.:
> >
> >                         } else if (strncmp(p, "remount", 7) == 0) {
> 
> What is the rationale behind this?

Primarily security and stability.  I won't get into a discussion about
this as it'll just bikeshed, particularly when there's an almost
indefinite amount of information online about the dangers of strcmp(3).

-- 
| Jeremy Chadwick                                   jdc at koitsu.org |
| UNIX Systems Administrator                http://jdc.koitsu.org/ |
| Making life hard for others since 1977.             PGP 4BD6C0CB |



More information about the freebsd-fs mailing list