[CFR][DEVFS] Add "ruleset" mount option

[Konstantin Belousov]

On Mon, Feb 06, 2012 at 02:00:22PM +0100, Martin Matuska wrote:
> On 6. 2. 2012 13:36, Konstantin Belousov wrote:
> > On Mon, Feb 06, 2012 at 10:26:17AM +0100, Martin Matuska wrote:
> >> The devfs(8) command supports configuring specific rulesets for devfs(5)
> >> mounts.
> >> However, it operates on already mounted devfs filesystems only and it is
> >> impossible to configure a specific ruleset on mount-time.
> >>
> >> The attached patch adds a "ruleset" mount option to devfs mounts.
> >> The ruleset is automatically applied upon mount time. If the ruleset
> >> doesn't exist, an empty ruleset with the given numer is created and
> >> can be modified with devfs(8) later.
> >>
> >> The patch is also available at:
> >> http://people.freebsd.org/~mm/patches/devfs/devfs_mount_ruleset.patch
> >>
> >> Please review and/or comment my attached patch.
> >>
> > Did you tested this with witness turned on ? It seems not.
> Yes, I did, no warnings or error messages on my console.

Are you sure ? Did you tried to change rulesets after mounting
some devfs with ruleset option ?

From what I see, sx_rules is after dm_lock, e.g. in devfs_rules_ioctl(),
while your patch insists on reversed order.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20120206/120befc3/attachment.pgp