kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD

[Kostik Belousov]

On Sat, Mar 26, 2011 at 07:12:05AM -0700, Pedro F. Giffuni wrote:
> 
> --- On Sat, 3/26/11, Kostik Belousov <kostikbel at gmail.com> wrote:
> 
> ...
> > Ok, after rereading the code, I do not believe that we need
> > the change. The doscheckpath() does vput() on tdvp, and tvp
> > is vput'ed right before line 1083, so jumping to the label
> > `bad' instead of `out' will only result in the lock
> > assertion being fired.
> > 
> > Also, the msdosfs mount correctly unmounts after the
> > attempt to perform a rename that doscheckpath() banned.
> > This is additional evidence supporting my point.
> > 
> > The question is, why did you decided that the fix is needed
> > for FreeBSD ?
> >
> 
> Defensive programming. On NetBSD this apparently started
> causing problems for unknown reasons, and doing the change
> doesn't have any ill effect on FreeBSD.
What is defensive in introducing the bug ?
The change, applied to FreeBSD, will cause panic.

> 
> I am OK, if you want to close the PR though, and thanks for
> doing the complete research.
> 
> Pedro.
> 
> 
> 
>       
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20110326/635ba621/attachment.pgp