kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD

Pedro F. Giffuni giffunip at tutopia.com
Fri Mar 25 18:13:40 UTC 2011


Hello;
--- On Fri, 3/25/11, Kostik Belousov <kostikbel at gmail.com> wrote:
...
> >  Fixes NetBSD PR #44661
> Can you extract the test referenced in the commit message
> ?
Here is the NetBSD link:

http://cvsweb.netbsd.org/bsdweb.cgi/src/tests/fs/vfs/t_vnops.c.diff?r1=1.21&r2=1.22

but I have no idea if it will apply to our testing framework.

> 
> I think that s/EROFS/EINVAL/ change could and should be
> committed first, and then the (potential) fix for the
> vnode leakage as a separate commit.
>

It takes some time to get patches committed, so I usually
prefer to submit bigger patches, if I can, in order to save
reviewer's time.

FWIW, I prefer so much bugzilla since permits better patch
handling and obsoleting the diffs that have been applied
already. 


      


More information about the freebsd-fs mailing list