exporting non-mpsafe file systems - VFS_NEEDSGIANT()

[Kostik Belousov]

On Mon, Jan 03, 2011 at 04:34:22PM -0500, Rick Macklem wrote:
> Hi,
> 
> The code currently in the experimental NFS server w.r.t. handling
> VFS_LOCK_GIANT()/VFS_UNLOCK_GIANT() is currently BADLY broken.
> Fortunately, since the major file systems being exported are mpsafe
> and don't need Giant, nobody seems to be noticing.
> 
> Since the code is ugly and not easy to fix, I'd like to just delete
> it and only allow mpsafe file systems to be exported. (I looked at
> ufs/zfs/nullfs/msdosfs/cs9660 and they all appear to be mpsafe.)
> 
> So does anyone know of a non-mpsafe file system that needs to be
> exported or see other serious problems w.r.t. not allowing exporting
> of non-mpsafe file systems?
The only sami-important fs that is not mpsafe is smbfs.

I would say, go with the removal of VFS_LOCK_GIANT from the new
nfs server.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20110103/4f22f5e9/attachment.pgp