ext2fs: PR 153584, prealloc, etc.
Doug Barton
dougb at FreeBSD.org
Mon Jan 3 02:45:42 UTC 2011
Howdy,
Pedro,
Thanks for http://www.freebsd.org/cgi/query-pr.cgi?pr=153584 however it
does not compile on HEAD:
cc -O2 -pipe -g -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE
-nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include
/usr/local/obj/home/svn/head/sys/GENERIC/opt_global.h -I. -I@
-I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100
--param large-function-growth=1000 -fno-common -g -g
-fno-omit-frame-pointer -I/usr/local/obj/home/svn/head/sys/GENERIC
-mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3
-mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables
-ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector
-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
-Wno-pointer-sign -fformat-extensions -c
/home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c
/home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c: In
function 'ext2_checkoverlap':
/home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c:108:
error: dereferencing pointer to incomplete type
*** Error code 1
Stop in /home/svn/head/sys/modules/ext2fs.
*** Error code 1
I also notice that your work does not seem to include the preallocation
work of Aditya, which I've been running ever since the thread in
November and has been working well for me.
http://lists.freebsd.org/pipermail/freebsd-fs/2010-November/010024.html
Any chance you 2 could work together to come up with 1 patch that has
the best of both worlds, and actually compiles on HEAD? It would also be
really useful if the resultant patch was created using 'svn diff' as it
would be a lot easier for those of us who are interested in testing this
to do so, not to mention actually getting it committed.
Thanks,
Doug
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
More information about the freebsd-fs
mailing list