ZFS panic: wrong length 131072 for sectorsize 2352

Pawel Jakub Dawidek pjd at FreeBSD.org
Tue May 25 19:27:41 UTC 2010


On Tue, May 25, 2010 at 03:20:26AM -0500, James R. Van Artsdalen wrote:
> On 5/24/2010 10:27 AM, James R. Van Artsdalen wrote:
> > panic: wrong length 131072 for sectorsize 2352
> 
> This fixes the bug.

I don't think so:) size should be properly calculated at this point and
should be multiple of sectorsize. The problem is that vdev_geom_io()
splits request into MAXPHYS chunks if it is too big, which is wrong,
because MAXPHYS doesn't have to be multiple of sectorsize.

Could you try this patch instead:

	http://people.freebsd.org/~pjd/patches/vdev_geom.c.4.patch

> Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c
> ===================================================================
> --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c  (revision 208373)
> +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c  (working copy)
> @@ -250,6 +250,9 @@
>                 if ((offset % pp->sectorsize) != 0)
>                         continue;
> 
> +               if ((size % pp->sectorsize) != 0)
> +                       continue;
> +
>                 if (vdev_geom_io(cp, BIO_READ, label, offset, size) != 0)
>                         continue;
>                 buf = label->vl_vdev_phys.vp_nvlist;

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-fs/attachments/20100525/4cf3f705/attachment.pgp


More information about the freebsd-fs mailing list