nullfs: vop_rename: fdvp is locked but should not be

Kostik Belousov kostikbel at
Wed Jun 2 09:45:09 UTC 2010

On Wed, Jun 02, 2010 at 11:16:45AM +0300, Mikolaj Golub wrote:
>  KB> I am curious to look at the final patch. Note that you proposing to add
>  KB> fs-specific check to vfs_subr.c. Checking that the the vnode locks are
>  KB> different instead of that vnodes itself are different might be better
>  KB> approach for vop_rename_pre.
> Ok. Looks a bit tricky :-). Then may be it is safe just to skip ASSERT() if
> the "target" and "from" vnodes are on different fs, like in the patch below?
> I have tried the patch on CURRENT. It looks like it works...

I do not think that the attached patch is the right solution Again, try.
comparing the pointers to the vnode locks instead of the vnode pointers.

Something like
	if (a->a_tdvp->v_vnlock != a->a_fdvp->v_vnlock ...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url :

More information about the freebsd-fs mailing list