ata-disk.c:ad_init(): max_iosize might be uninitialized?

Alexander Motin mav at FreeBSD.org
Mon Jul 12 20:06:01 UTC 2010


Hi.

Mikolaj Golub wrote:
> It might be a wrong list but I have not found freebsd-ata@ or freebsd-disk@
> list -).
> 
> I just have looked accidentally at ad_init() in dev/ata/ata-disk.c and it
> looks like there is at least theoretical possibility that atadev->max_iosize
> remains uninitialized (if ata_controlcmd(ATA_SET_MULTI) fails). Shouldn't be
> like in the patch below?

It is not very obvious, but it is initialized in ata_add_child().

-- 
Alexander Motin


More information about the freebsd-fs mailing list