zfs arc - just take it all and be good to me

[Andriy Gapon]

on 25/08/2010 16:21 Ollivier Robert said the following:
> According to Andriy Gapon:
>> Could you please double-check?  Is the check for vm_paging_needed() indeed?
>> That could have been a slightly different patch.
> 
> 695 [15:19] root at centre:src/sys# svn diff cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c
> Index: cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c
> ===================================================================
> --- cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c    (revision 210515)
> +++ cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c    (working copy)
> @@ -2123,8 +2123,9 @@
>         /*
>          * If pages are needed or we're within 2048 pages
>          * of needing to page need to reclaim
> +     * XXX Try to workaround zfs overzealousness from gav/avg
>          */
> -       if (vm_pages_needed || (vm_paging_target() > -2048))
> +       if (vm_pages_needed)
>                 return (1);

Note that vm_pages_needed != vm_paging_needed().
Talk about confusing :)

-- 
Andriy Gapon