hastd segfaults reading metadata from not initialized provider

[Mikolaj Golub]

On Thu, 29 Apr 2010 00:43:26 +0200 Pawel Jakub Dawidek wrote:

 PJD> On Mon, Apr 26, 2010 at 11:07:31PM +0300, Mikolaj Golub wrote:
 >> Hi,
 >> 
 >> When configuring a new provider if one forgets to do 
 >> 
 >> hastctl create tank
 >> 
 >> before 
 >> 
 >> hastctl role primary tank

 PJD> In my tests I cannot reproduce it. If metadata is empty hastd should
 PJD> notice that, but check for NULL was missing anyway.

I observe this on VirtualBox hosts with virtual disks (dynamically expanding
storage).

 PJD> I fixed it a bit different. In general nv API is constructued in a way
 PJD> that the consumer might execute various calls and check for error at the
 PJD> end. This is what we do there already, only (str != NULL) check was
 PJD> missing. Thanks for the report, I committed fix to HEAD.

Thank you :-)

-- 
Mikolaj Golub