Pseudofs and pfs_attr_t for non-process based files
des at des.no
Thu Jan 22 07:21:12 PST 2009
Andrew Brampton <brampton+freebsd-fs at gmail.com> writes:
> Dag-Erling Smørgrav <des at des.no> writes:
> > Sounds sensible, but your patches are mangled. Could you please
> > regenerate them using 'svn diff -x-p' on a non-Windows machine?
> When you say mangled, did you just mean they had windows new lines?
That, and incorrect indentation, which your new patches fixed.
A tip: if your MUA allows it, set the MIME-type for patches to
text/x-patch (or, as last resort, text/plain), otherwise they may get
stripped by mailing list software and some corporate / institutional
In procfs_attr(), the vap->va_[ug]id assignments are redundant, since at
this point pfs_getattr() has already done the exact same thing. The
rest of the patch is fine, modulo style issues which already existed in
Dag-Erling Smørgrav - des at des.no
More information about the freebsd-fs