newfs: useless/bogus check if new last block can be accessed?

Juli Mallett jmallett at FreeBSD.org
Fri May 9 20:39:32 PDT 2003


* Ian Dowse <iedowse at maths.tcd.ie> [ Date: 2003-05-09 ]
	[ w.r.t. Re: newfs: useless/bogus check if new last block can be accessed? ]
> In message <20030509203228.A62797 at FreeBSD.org>, Juli Mallett writes:
> >(which went nowhere due to over-engineering, and too much faith...er, yeah,
> >it went nowhere), one of the things I wanted to do was have a "naive" flag
> >as part of an (undeveloped) generalised flags (external, not like MINE_)
> >interface, which would let libufs do the exploding, if things went wrong.
> 
> Something like the patch below should do the trick for now. This
> puts back the old exit code and sector number information, but
> relies on the undocumented (?) behaviour of bwrite() leaving a
> sensible value in errno.

That looks pretty sane.  And bwrite is undocumented.  All contracts
are explicit for now.  Once it's documented that changes.

Thanx,
juli.
-- 
juli mallett. email: jmallett at freebsd.org; efnet: juli;


More information about the freebsd-fs mailing list