E on FreeBSD: maintainer-feedback requested: [Bug 238677] devel/efl: Leaks event monitor fds into child processes

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-enlightenment
mailing list <enlightenment at FreeBSD.org> for maintainer-feedback:
Bug 238677: devel/efl: Leaks event monitor fds into child processes
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238677



--- Description ---
Please see the full report text in this upstream issue:
https://phab.enlightenment.org/T7486

The fix is trivial -- add O_CLOEXEC to an open.  I thought upstream might fix
it, but it does not appear they will.  So we might consider patching it in
ports.

The patch to fix is totally trivial:

--- ./eio_monitor_kevent.c.orig 2019-06-17 19:34:47.015700000 -0700
+++ ./eio_monitor_kevent.c	2019-06-17 19:35:04.938381000 -0700
@@ -271,7 +271,7 @@
    res = stat(monitor->path, &st);
    if (res) goto error;

-   fd = open(monitor->path, O_RDONLY);
+   fd = open(monitor->path, O_RDONLY | O_CLOEXEC);
    if (fd < 0) goto error;

    backend->fd = fd;