fwd: CFR: patch to cleanup usage of SRC_BASE in various ports
Alexander Leidinger
Alexander at Leidinger.net
Thu Dec 2 09:14:43 UTC 2010
Quoting Mark Linimon <linimon at lonesome.com> (from Wed, 1 Dec 2010
15:33:35 +0000):
> On Wed, Dec 01, 2010 at 01:22:20PM +0100, Alexander Leidinger wrote:
>> If you have a strong argument for this change, I do not object to it,
>> but if you do not have a strong argument, I would prefer to not get
>> this change.
>
> The problem I have is that I want pointyhat to build an INDEX based on
> what is the current "best recommended value" of the linux emulation,
> not whatever happens to be on pointyhat at the moment. (It turns out
> that right now this "Just Works" on pointyhat but only so; it does not
> work on the new codebase on pointyhat-west, where a very minimal subset
> of ports is installed).
Looks like a strong argument to make the change. :)
> Just setting LINUX_OSRELEASE at the top level didn't seem to work; it
> appears the != line overrides that setting.
Yes, it is evaluated after your command line or env settings, not before.
> How about this? We change the override to only work if PACKAGE_BUILDING
> is set?
This looks like a good plan.
Bye,
Alexander.
--
We're happy little Vegemites,
As bright as bright can be.
We all enjoy our Vegemite
For breakfast, lunch and tea.
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
More information about the freebsd-emulation
mailing list