VirtualBox 3.2.0-beta-1 fails to compile on -current

[Jung-uk Kim]

On Thursday 29 April 2010 06:37 pm, Jung-uk Kim wrote:
> On Thursday 29 April 2010 05:35 pm, Michael Butler wrote:
> > Something is amiss with the ACPI code ..
> >
> > kBuild: Compiling DevicesR3 -
> > /usr/home/imb/svn/virtualbox-ose/work/VirtualBox-3.2.0_OSE/src/VB
> >ox /Devices/PC/DevPIC.cpp kBuild: Compiling DevicesR3 -
> > /usr/home/imb/svn/virtualbox-ose/work/VirtualBox-3.2.0_OSE/src/VB
> >ox /Devices/PC/DevACPI.cpp kBuild: iasl DevicesR3 -
> > /usr/home/imb/svn/virtualbox-ose/work/VirtualBox-3.2.0_OSE/src/VB
> >ox /Devices/PC/vbox.dsl
> > /usr/home/imb/svn/virtualbox-ose/work/VirtualBox-3.2.0_OSE/src/VB
> >ox /Devices/PC/vbox.dsl 998:                      0xdfdfffff, //
> > Range Length (calculated
> > Error    4118 -
> >          Length is not equal to fixed Min/Max window ^
> >
> > ASL Input:
> > /usr/home/imb/svn/virtualbox-ose/work/VirtualBox-3.2.0_OSE/src/VB
> >ox /Devices/PC/vbox.dsl - 1305 lines, 46225 bytes, 288 keywords
> > Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 404
>
> The fixed range check is newly added feature of ACPICA 20100428.
>
> - sys/contrib/dev/acpica/changes.txt
>
> iASL: Implemented Min/Max/Len/Gran validation for address resource
> descriptors. This change implements validation for the address
> fields that are common to all address-type resource descriptors.
> These checks are implemented: Checks for valid Min/Max, length
> within the Min/Max window, valid granularity, Min/Max a multiple of
> granularity, and _MIF/_MAF as per table 6-40 in the ACPI 4.0a
> specification. Also split the large aslrestype1.c and aslrestype2.c
> files into five new files. ACPICA BZ 840.
>
> If the comment in the vbox.dsl is correct, the range will be
> dynamically patched at runtime.  Please try the attached patch. 
> It's against 3.1.6 but the line seems the same.  At least, it
> should work around the build problem. ;-)

I read the source again and I found it is not "patched" by the 
emulator itself.  It's done from usual _CRS method.  Please try the 
attached patch instead.

Sorry about the confusion.

Jung-uk Kim
-------------- next part --------------
--- src/VBox/Devices/PC/vbox.dsl.orig	2010-03-25 15:56:03.000000000 -0400
+++ src/VBox/Devices/PC/vbox.dsl	2010-04-29 19:14:38.000000000 -0400
@@ -1064,7 +1064,7 @@
                              // (all of low memory space)
                      ResourceProducer,        // bit 0 of general flags is 0
                      PosDecode,               // positive Decode
-                     MinFixed,                // Range is fixed
+                     MinNotFixed,             // Range is not fixed
                      MaxFixed,                // Range is fixed
                      Cacheable,
                      ReadWrite,
@@ -1073,7 +1073,7 @@
 
                      0xffdfffff,              // Max = 4GB - 2MB
                      0x00000000,              // Translation
-                     0xdfdfffff,              // Range Length (calculated
+                     0x00000000,              // Range Length (calculated
                                               // dynamically)
                      ,                        // Optional field left blank
                      ,                        // Optional field left blank