Linux major/minor conversion not entirely correct
rdivacky at FreeBSD.org
Mon Jun 2 07:54:02 UTC 2008
On Mon, Jun 02, 2008 at 09:31:52AM +0200, Ed Schouten wrote:
> Hello everyone,
> The last couple of months I've been working on redesigning FreeBSD's TTY
> layer. This is all going quite good. Too good, actually.
> Last week I've been toying around with getting sshd working inside a
> Linux jail, which seems to work quite nicely right now. I've made some
> changes to our Linux compat layer that could already get (partially)
> merged back to SVN.
> The Linux compat layer generates fake major/minor numbers for certain
> devices, because Linux still depends on that information a lot (yuck).
> I've discovered that our Linux compat layer returns the same major/minor
> pair for all nodes in /dev/pts, but doesn't do this consistently either.
> We'd better push the conversion down into linux_driver_get_major_minor(),
> to make sure the numbers always get converted. We should also make sure
> we hand out unique numbers.
> The patch also contains a change I made to support the new DTYPE_PTS
> (pseudo-terminal master device). This part of the diff should be
> ignored. I've just added it for completeness.
> Does anyone mind if I commit this patch soonish?
I dont see a problem with it... go commit that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-emulation/attachments/20080602/1370da97/attachment.pgp
More information about the freebsd-emulation