compat/linprocfs

John Hein jhein at timing.com
Sat Nov 24 16:57:18 PST 2007


Roman Divacky wrote at 23:19 +0100 on Nov 24, 2007:
 > in
 > compat/linprocfs/linprocfs.c:linprocfs_doprocmaps() there's 
 > 
 >         unsigned int last_timestamp;
 > 
 > variable declaration, this variable is used only once in this function:
 > 
 >         if (last_timestamp + 1 != map->timestamp) {
 > 
 > ie. the map->timestamp is compared to some stack garbage + 1. this does not
 > seem to be correct, the last_timestamp must be set somewhere..
 > 
 > comments?

It is set 6 lines earlier...

		last_timestamp = map->timestamp;
		vm_map_unlock_read(map);
		error = uiomove(mebuffer, len, uio);
		vm_map_lock_read(map);
		if (error)
			break;
		if (last_timestamp + 1 != map->timestamp) {


More information about the freebsd-emulation mailing list