qemu hack

[Juergen Lock]

On Fri, Jan 20, 2006 at 10:50:06AM +0900, NAKATA Maho wrote:
> In Message-ID: <20060119192137.GB13509 at saturn.kn-bremen.de> 
> Juergen Lock <nox at jelal.kn-bremen.de> wrote:
> 
> > On Wed, Jan 18, 2006 at 09:37:40AM +0900, NAKATA Maho wrote:
> > > Dear Juergen and list,
> > > I add a hack for qemu port; speed up hack of cirrus vga.
> > > http://lists.gnu.org/archive/html/qemu-devel/2006-01/msg00208.html
> > > and now qemu seems to be faster a bit.
> > > (hope someone can do benchmark)
> > > 
> > > Juergen, can I commit to port?
> > 
> > Well you didnt bump PORTREVISION, also you could call patch with --quiet
> Right. According to
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html
> 
> > PORTREVISION should be increased each time a change is made to the port which significantly affects the content or structure of the derived package.
> > Changes to MASTER_SITES or other functional changes to the port which do not affect the resulting package.
> 
> My understanding is adding a knob do not affect the resulting packages
> since I didn't change anything when installing with `make install' (but
> make -DWITH_HACKS install).
> 
> I took this way - since adding unofficial patches are considered as
> minor project fork and as you found below, there might be a side effects
> as well. IMHO any patch should be upstreamed otherwise
> we should fork the project. so I merely added as a knob.
> 
Well, I'm all for the knob, I was just thinking e.g. about someone who has
WITH_HACKS in his pkgtools.conf and then portupgrades qemu...