[PATCH] SDIO support for Globalscale Dreamplug
Jeroen Hofstee
freebsd_arm at myspectrum.nl
Thu Jul 4 17:42:51 UTC 2013
Hello Warner,
On 07/04/2013 06:09 PM, Warner Losh wrote:
> On Jul 3, 2013, at 11:47 PM, Jeroen Hofstee wrote:
>
>> Hello Ilya,
>>
>> On 07/04/2013 12:20 AM, Ilya Bakulin wrote:
>>> So some bytes lack 0x40... This problem occurs also with other numbers
>>> read from the card, for example, vendor ID is read as 0x029F instead of 0x02DF.
>>> +/* Halfword bit masks used for command response extraction. */
>>> +#define MV_SDIO_RSP48_BM2 0x0002 /* Lower 2 bits. */
>>> +#define MV_SDIO_RSP48_BM6 0x003f /* Lower 6 bits. */
>>> + /* Response bits [15:14] and [13:8] */
>>> + *rp++ = (resp[2] & MV_SDIO_RSP48_BM6) |
>>> + ((word & MV_SDIO_RSP48_BM2) << 6);
>>> +
>> From the looks if it, MV_SDIO_RSP48_BM2 must be 3 instead 2.
> And 0x0031 doesn't look right either... I'd have expected 0x3f.
which 0x0031 (perhaps I need to have my eyes checked....)?
Regards,
Jeroen
More information about the freebsd-embedded
mailing list