java/eclipse: error building WITH_MOZILLA=mozilla

[Panagiotis Astithas]

Andreas Kohn wrote:
> On Thu, 2005-09-15 at 16:02 +0300, Panagiotis Astithas wrote:
> 
>>Andreas Kohn wrote:
>>
>>>Hi,
>>>
>>>On Thu, 2005-09-15 at 09:36 +0300, Panagiotis Astithas wrote:
>>>
>>>
>>>>barbara.xxx1975 wrote:
>>>>
>>>>
>>>>>port version:
>>>>># $FreeBSD: ports/java/eclipse/Makefile,v 1.38 2005/09/14 14:46:36 nork Exp $
>>>>>
>>>>>I keep getting an error if I try to upgrade(from eclipse-3.1_1) or build eclipse with WITH_MOZILLA=mozilla.
>>>>>This doesn't happen if I use the WITH_MOZILLA=firefox.
>>>>>
>>>>>*UPDATE* (this happened while I was writing):
>>>>>When I tryed to build eclipse WITH_MOZILLA=mozilla these ports where not installed:
>>>>>nspr-4.6_1
>>>>>nss-3.10
>>>>>firefox-1.0.6_5,1
>>>>>I had them installed to try with WITH_MOZILLA=firefox.
>>>>>Now it builds also with WITH_MOZILLA=mozilla.
>>>>>As eclipse does not run-depends on them, could I safely pkg_delete them?
>>>>>Or should I keep them to avoid to install them again on the next eclipse upgrade?
>>>>
>>>>You are not supposed to ever use WITH_MOZILLA=mozilla. 
>>>
>>>I don't like this at all. WITH_MOZILLA=mozilla is a perfectly valid
>>>setting for other mozilla-using ports, and people probably have their
>>>preference in /etc/make.conf (I do).
>>
>>Never heard of that before. Can you mention the ports that have such a 
>>complete logic that can handle all variations? I'd like to copy their logic.
> 
> 
> Every mozilla-using port uses a different logic for interpreting
> WITH_MOZILLA. 

I've noticed :-)
But even this port does not mention in its pre-everything message 
setting WITH_MOZILLA=mozilla, presumably because it is considered 
redundant. Nevertheless, since there are long-time users out there who 
do this, eclipse must accomodate.

> One example would be x11/yelp:
> http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/x11/yelp/Makefile?rev=1.39&content-type=text/plain
> This Makefile has a default for mozilla, and can work with all other
> mozillas. 
> The x11/yelp/Makefile from gnome 2.12 ports at 
> http://www.marcuscom.com:8080/cgi-bin/cvsweb.cgi/~checkout~/ports/x11/yelp/Makefile?rev=1.60&content-type=text/plain
> even has a default of firefox instead of mozilla.
> 
> The only mozilla missing here would be firefox-devel, but that's quite
> easy to handle as well. 

I see that this port does not have a case where one would want 
WITHOUT_MOZILLA functionality. I think your patch may be enough for 
eclipse. If you could verify it works for your case, I'd say send-pr it.

Regards,

Panagiotis