ports/86860: [patch] Align java/eclipse invocation with javavmwrapper

[Herve Quiroz]

The following reply was made to PR ports/86860; it has been noted by GNATS.

From: Herve Quiroz <herve.quiroz at esil.univ-mrs.fr>
To: bug-followup at FreeBSD.org, past at ebs.gr
Cc:  
Subject: Re: ports/86860: [patch] Align java/eclipse invocation with javavmwrapper
Date: Mon, 10 Oct 2005 17:00:27 +0200

 Hi,
 
 I am a bit late on this topic (PR already closed) but I just noticed a
 flaw with this change.
 
 javavmwrapper picks a JDK depending on several variables -- see
 javavm(1). With this change it is possible that a not suitable JDK gets
 picked up. Here is a patch that should fix this (I didn't test it
 though).
 
 
 Index: files/eclipse.in
 ===================================================================
 RCS file: /home/ncvs/ports/java/eclipse/files/eclipse.in,v
 retrieving revision 1.5
 diff -u -r1.5 eclipse.in
 --- files/eclipse.in	9 Oct 2005 14:54:21 -0000	1.5
 +++ files/eclipse.in	10 Oct 2005 14:54:13 -0000
 @@ -46,4 +46,4 @@
  	exit 1
  fi
  
 -PATH=${JAVA_HOME}/bin:$PATH exec "${ECLIPSE_HOME}/eclipse" $@
 +JAVA_VERSION="%%JAVA_VERSION%%" JAVA_OS="%%JAVA_OS%%" PATH=${JAVA_HOME}/bin:$PATH exec "${ECLIPSE_HOME}/eclipse" $@