IWN Review

[Cedric GROSS]

> De : adrian.chadd at gmail.com [mailto:adrian.chadd at gmail.com] De la part
> de Adrian Chadd
> Envoyé : dimanche 21 juillet 2013 06:06
> À : Cedric GROSS
> Cc : freebsd-wireless at freebsd.org; freebsd-drivers at freebsd.org
> 
> Hi!
> 
> so, my feedback!
> 
> * Why'd you disable including opt_wlan.h ? It's required
Just because I worked with a 9.1-release and I don't reach to compile iwn
with this include. Forget to enable it again.

> * What merge issues did you have? I'd like to get this tree updated to
> the latest -HEAD, including whatever my recent changes for rate
> selection, so we can get this stuff tidied up for -HEAD
Ok I will try.

> * Why was ieee80211_resume_all() commented out? Did you do this?
This things was not in original IWL so I commented it to be sure that my
version of IWN work as iwl do. Plan to uncomment when merging to HEAD.

> 
> There's some stuff we can merge in right now into -HEAD:
> 
> * the debug improvements
> * the changes from hard-coded checks for features based on the chipset,
> to a bitmap of features that get set during probe/attach
> 
> So, let's try to get your stuff updated to the latest -HEAD, then get
> it tested out. I'll then start merging this stuff into -HEAD as we
> figure out what all these pieces do.
> 
> Thanks for all this hard work!
> 
> 
> 
> -adrian
> 
> 
> On 20 July 2013 07:18, Cedric GROSS <cg at cgross.info> wrote:
> > Hello dear all,
> >
> >
> >
> > I'm please to announce that I completed my work on IWN.
> >
> >
> >
> > My version available here https://github.com/KreizIT/FreeBSD-IWN
> > include improvement issued by seanbruno
> > (https://github.com/seanbruno/freebsd-iwl)
> > but also mine to support centrino N 2230 NIC (it's my NIC)
> >
> >
> >
> > I set up a new parameters system which more sensitive. I port back
> all
> > NIC parameters to this new system. I hope that I haven't do some
> mistake.
> >
> > So I'll be really please if Intel's NIC owner could check my work and
> > let me know.
> >
> >
> >
> > By the way, if commiters would include my work, please do.
> >
> >
> >
> > Cheers
> >
> > Cedric
> >
> >
> >
> > _______________________________________________
> > freebsd-wireless at freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless
> > To unsubscribe, send any mail to "freebsd-wireless-
> unsubscribe at freebsd.org"