docs/122906: [patch] Fix makevar, maketarget Tags in Handbook Chapter 4.

Gabor PALI pgj at FreeBSD.org
Sat Apr 19 12:10:06 UTC 2008


The following reply was made to PR docs/122906; it has been noted by GNATS.

From: Gabor PALI <pgj at FreeBSD.org>
To: Marc Fonvieille <blackend at FreeBSD.org>
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: docs/122906: [patch] Fix makevar, maketarget Tags in Handbook
 Chapter 4.
Date: Sat, 19 Apr 2008 14:02:00 +0200

 Marc Fonvieille wrote:
 > On Sat, Apr 19, 2008 at 12:51:39PM +0200, Gabor PALI wrote:
 >>> Number:         122906
 >>> Category:       docs
 >>> Synopsis:       [patch] Fix makevar, maketarget Tags in Handbook Chapter 4.
 >>> Confidential:   no
 >>> Severity:       non-critical
 >>> Priority:       low
 >>> Responsible:    freebsd-doc
 >>> State:          open
 >>> Quarter:        
 >>> Keywords:       
 >>> Date-Required:
 >>> Class:          doc-bug
 >>> Submitter-Id:   current-users
 >>> Arrival-Date:   Sat Apr 19 11:00:01 UTC 2008
 >>> Closed-Date:
 >>> Last-Modified:
 >>> Originator:     Gabor PALI
 >>> Release:        FreeBSD 6.3-STABLE i386
 >>> Organization:
 >>> Environment:
 >> System: FreeBSD disznohal 6.3-STABLE FreeBSD 6.3-STABLE #4: Fri Apr 4 23:29:43 CEST 2008 dezzy at disznohal:/usr/obj/usr/src/sys/GENERIC_ i386
 >>
 >>> Description:
 >> 	I found a small inconsistency in the use of maketarget, makevar
 >> 	tags in SGML source of the Handbook chapter titled ``Packages and
 >> 	Ports''. So, I created a patch to unify their usage and
 >> 	<command>make <maketarget>all consistent</maketarget></command>
 >> 	in the <makevar>PORTS_CHAPTER</makevar> :)
 >> 	
 >>
 >> --- ports.patch.diff begins here ---
 > [...]
 > 
 > Hello,
 > 
 > This patch mixes content and whitespace/wrapline changes.  We use to
 > not commit changes to the content at the same time as changes to the
 > layout.  These changes must be done in 2 separated patches, well most of
 > time we don't do the formatting changes or only when the file starts to
 > be a mess.
 > To come back to the content, the changes seem Ok for me but please
 > send a content changes only patch.
 > 
 
 Dear Marc,
 
 Thank you for your comment, it will be done. I know the rule you pointed
 out, although I thought the patch will not break it.
 
 Should I "invalidate" this PR or can I edit it in some way?
 
 
 Cheers,
 -pgj
 
 
 PS: Is this a right way to send my patches to (peer) review?
 
 



More information about the freebsd-doc mailing list