docs/90362: [patch] enhancement of devfs.rules manpage.
rsmith at xs4all.nl
Mon Jan 23 18:40:08 UTC 2006
The following reply was made to PR docs/90362; it has been noted by GNATS.
From: Roland Smith <rsmith at xs4all.nl>
To: Giorgos Keramidas <keramida at freebsd.org>
Cc: bug-followup at freebsd.org
Subject: Re: docs/90362: [patch] enhancement of devfs.rules manpage.
Date: Mon, 23 Jan 2006 19:39:01 +0100
Content-Type: text/plain; charset=us-ascii
On Mon, Jan 23, 2006 at 03:30:02AM +0200, Giorgos Keramidas wrote:
> > --- devfs.rules.5 2005/12/13 19:59:29 1.6
> > +++ devfs.rules.5 2005/12/13 21:19:53
> > .Pp
> > +.Dl "[localrules=3D10]"
> > .Dl "add path 'da*s*' mode 0660 group usb"
> > .Pp
> > +The first line declares and starts a new ruleset, with the name
> > +.Va localrules
> > +and the number 10. Rulesets should have a unique name and number. All
> "Rulesets should have a unique name and number" is duplicated here,
> since it's also mentioned higher up, in the DESCRIPTION section.
> > +rules that follow a ruleset declaration belong to that ruleset, untill=
> "untill" is a minor typo.
> Overall this is a great idea though, but I'd probably move the general
> ruleset description items in the DESCRIPTION section. If the following
> looks ok to you too Roland, it would be nice to have it committed I
It's mostly OK, except for some small remarks below:
> Index: devfs.rules.5
> RCS file: /home/ncvs/src/share/man/man5/devfs.rules.5,v
> retrieving revision 1.2
> diff -u -r1.2 devfs.rules.5
> --- devfs.rules.5 16 Jun 2005 18:46:17 -0000 1.2
> +++ devfs.rules.5 23 Jan 2006 01:29:23 -0000
> @@ -24,7 +24,7 @@
> .\" $FreeBSD: src/share/man/man5/devfs.rules.5,v 1.2 2005/06/16 18:46:17=
ru Exp $
> -.Dd May 17, 2005
> +.Dd Jan 23, 2006
> .Dt DEVFS.RULES 5
> .Sh NAME
> @@ -60,6 +60,27 @@
> It is important to put path elements that contain
> .Xr glob 3
> special characters between quotes.
> +Rulesets should have a unique name and number.
> +All rules that follow a ruleset declaration belong to that ruleset, unti=
> +new ruleset is started.
This should be singular, not plural, since only one ruleset can be
enabled for /dev, so:
-All custom rulesets have to be enabled in
+One custom ruleset has to be enabled in
> +.Pa /etc/rc.conf ,
-otherwise they won't be applied to the
+otherwise it won't be applied to the
> +.Pa /dev
> +file system by the default system startup process.
> +For example, to enable a
> +.Dq Li localrules
> +ruleset for the
> +.Pa /dev
> +file system, you would have to use something like this in your
> +.Pa rc.conf
> +.Bd -literal -offset indent
> .Sh FILES
> .Bl -tag -compact
> .It Pa /etc/devfs.rules
> @@ -72,14 +93,20 @@
> .Dq Li usb
> group, the following rule may be used:
> +.Dl "[localrules=3D10]"
> .Dl "add path 'da*s*' mode 0660 group usb"
> +The first line declares and starts a new ruleset, with the name
> +.Va localrules
> +and the number 10.
> To make all the
> .Xr uscanner 4
> devices accessible to their owner and the
> .Dq Li usb
> group, a similar rule may be used:
> +.Dl "[uscanner=3D20]"
You should not start an extra ruleset here. The following rule is for
the /dev filesystem, and should therefore belong to the "localrules"
set. AFAIK, you can activate only _one_ ruleset for /dev in /etc/rc.conf
via devfs_system_ruleset (see /etc/rc.d/devfs).=20
The variable devfs_set_rulesets is meant for other mountpoints.
> .Dl "add path 'uscanner*' mode 0660 group usb"
> .Sh SEE ALSO
> .Xr glob 3 ,
The rest of the patch looks OK.
R.F.Smith (http://www.xs4all.nl/~rsmith/) Please send e-mail as plain text.
public key: http://www.xs4all.nl/~rsmith/pubkey.txt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
-----END PGP SIGNATURE-----
More information about the freebsd-doc