docs/77851: articles/committers-guide: change Approved -> Reviewed

Florent Thoumie flz at xbsd.org
Mon Feb 21 12:30:20 UTC 2005


The following reply was made to PR docs/77851; it has been noted by GNATS.

From: Florent Thoumie <flz at xbsd.org>
To: "Simon L. Nielsen" <simon at FreeBSD.org>
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed
Date: Mon, 21 Feb 2005 13:24:59 +0100

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig652565EE2E8C582CE3347021
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Simon L. Nielsen wrote:
 > On 2005.02.21 12:59:15 +0100, Florent Thoumie wrote:
 >
 >
 >>These are two different statements of the Committer's Guide. I think the
 >>second one is erroneous.
 >
 >
 > It isn't, it's different topics.
 >
 >
 >>"Approved by" is only acceptable from non-mentored src committers -- mentored
 >>committers can provide a "Reviewed by" but not an "Approved by".
 >
 >
 > This is from the "2.1 Policy for doc/ committer activity in src/"
 > section, ie. only for doc committers (if they are mentored or not)
 > and only wrt. commtting to src/.
 >
 >
 >>Until your mentor decides (and announces with a forced commit to access) that
 >>you have learned the ropes and are ready to commit on your own, you should not
 >>commit anything without first getting your mentor's review and approval, and
 >>you should document that approval with an Approved by: line in the commit
 >>message.
 >
 >
 > This is general for all committers being mentored and is correct
 > (though not entirely at least wrt. to doc/ people but that's another
 > matter).
 
 	Ok this was a bit unclear, though i read these parts 2 or 3
 	times.
 
 	Thanks.
 
 --------------enig652565EE2E8C582CE3347021
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.0 (FreeBSD)
 Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
 
 iD8DBQFCGdMfMxEkbVFH3PQRArFEAJ46jgRVamwzkW7V2PjSi4a9gI/2KQCcCGyY
 pXAFsZZl0J2qvkdZuDaWjR4=
 =Nqs4
 -----END PGP SIGNATURE-----
 
 --------------enig652565EE2E8C582CE3347021--



More information about the freebsd-doc mailing list