whitespace cleanup Q

Marc Fonvieille blackend at freebsd.org
Tue Aug 10 12:45:29 UTC 2004


On Tue, Aug 10, 2004 at 04:05:23PM +0400, Dmitry Morozovsky wrote:
> Dear colleagues,
> 
> preparing for my traditional first set of commits I found that (at least)
> contributors article contains way too much whitespace-only lines:
> 
> marck at woozle:~/FreeBSD/doc/en_US.ISO8859-1/articles/contributors> grep -c '^[   ][      ]*$' *sgml
> article.sgml:1
> contrib.386bsd.sgml:95
> contrib.additional.sgml:0
> contrib.committers.sgml:325
> contrib.core.sgml:7
> contrib.corealumni.sgml:26
> contrib.develalumni.sgml:2
> contrib.staff.sgml:0
> 
> What is the most preferred way to fix this?
>

That has been covered many times (see -doc archives etc.)
Most of time whitespace commits are useless, they just add bloat to the
CVS repo.  And since a fix today does not prevent a whitespace addition
on tomorrow...

contrib.committers.sgml:325 seemed a lot for me.  After a quick check,
it appears that these whitespaces have been added during the article.sgml
split :((
People use to edit this file at least once and just copy&paste a
part, they copy whitespaces without knowing it.  So this file should be
fixed to avoid "spread of whitespaces".

Few months ago we did a clean of the contrib.additional.sgml file for
the same reason, I'm glad to see no new whitespaces have been added :)

My opinion is: let fix contrib.committers.sgml, contrib.386bsd.sgml
(95 is a lot too) and maybe contrib.corealumni.sgml, the remaining does
not worth a commit.

Well this does not prevent us to take care of these problems before
committing anything.

Marc



More information about the freebsd-doc mailing list