docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook

Josef El-Rayes josef at daemon.li
Sun Dec 14 17:30:21 UTC 2003


The following reply was made to PR docs/60107; it has been noted by GNATS.

From: Josef El-Rayes <josef at daemon.li>
To: Lukas Ertl <l.ertl at univie.ac.at>
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook
Date: Wed, 10 Dec 2003 10:00:36 +0000

 Lukas Ertl <l.ertl at univie.ac.at> wrote:
 > +#include <sys/param.h>  /* defines used in kernel.h */
 > -#include <sys/param.h>  /* defines used in kernel.h */
 
 hi lukas!
 
 it is a good idea to have a look at the diff-generated patch
 before sending in, to avoid bogus lines like this.
 
 for example when you move a line(i.e. remove & insert at another
 place), you get such behaviour in your patch which makes it hard to read.
 
 keep up the good work :)
 greets, josef



More information about the freebsd-doc mailing list