problem with colored diffs

[Michael W. Lucas]

On Wed, Feb 27, 2008 at 08:16:01AM -0800, Mark Koopman wrote:
> We had a similar problem with diffs in general, and
> I had to add a call to umask to fix the problem.
> 
>   ## line 2338 cvsweb
>   if (!open($fh, "-|")) {    # child
>     open(STDERR, ">&STDOUT");    # Redirect stderr to stdout
>     openOutputFilter();
>     # adding umask to fix CVSWEB diff
>     umask 0022;
>     exec($CMD{rcsdiff}, @rcsdiff_options, @difftype, "-r$rev1", "-r$rev2",
>          $fullname) or exit -1;
>   }
> 
> diff cvsweb.cgi.orig cvsweb.cgi
> 2337a2338
> >    # adding umask to fix CVSWEB diff
> >    umask 0022;


Thanks for the suggestion.  I tried it.  No success, but I did get
different behavior.

Rather than failing silently, firefox tells me that it's trying to
open the file "hostname.diff", and would I like to save or open it?
It's a 0-size file.

Thanks,
==ml


> 
> 
> -----Original Message-----
> From: owner-freebsd-cvsweb at freebsd.org on behalf of Michael W. Lucas
> Sent: Wed 2/27/2008 4:10 AM
> To: cvsweb at freebsd.org
> Subject: problem with colored diffs
>  
> Hi,
> 
> I'm using cvsweb-3.0.6_1 on FreeBSD/amd64 7.0-beta2.
> 
> Everything except the colored diffs works flawlessly.
> 
> When I try to get a colored diff, however, the page comes up blank.
> No error message is logged in the Apache logs or in /var/log/messages;
> it appears to fail silently.
> 
> Any suggestions on how I can capture an error message, or otherwise
> debug this further?
> 
> Thanks,
> ==ml
> 
> -- 
> Michael W. Lucas 	mwlucas at BlackHelicopters.org, mwlucas at FreeBSD.org
> 		http://www.BlackHelicopters.org/~mwlucas/
>       Now Shipping: "Absolute FreeBSD" -- http://www.AbsoluteFreeBSD.com
> On 5/4/2007, the TSA kept 3 pairs of my soiled undies "for security reasons."
> _______________________________________________
> freebsd-cvsweb at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb
> To unsubscribe, send any mail to "freebsd-cvsweb-unsubscribe at freebsd.org"
> 
> 

-- 
Michael W. Lucas 	mwlucas at BlackHelicopters.org, mwlucas at FreeBSD.org
		http://www.BlackHelicopters.org/~mwlucas/
      Now Shipping: "Absolute FreeBSD" -- http://www.AbsoluteFreeBSD.com
On 5/4/2007, the TSA kept 3 pairs of my soiled undies "for security reasons."