nvidia-driver build error (last ports, FreeBSD-HEAD)

[Alan Cox]

On 08/22/2018 10:29, Alan Cox wrote:
> On 08/22/2018 08:48, tech-lists wrote:
>> On 22/08/2018 05:29, Manfred Antar wrote:
>>>> On Aug 21, 2018, at 7:23 PM, Alexey Dokuchaev<danfe at freebsd.org> 
>>>> wrote:
>>>>
>>>> On Tue, Aug 21, 2018 at 11:22:56PM +0700, Alex V. Petrov wrote:
>>>>> -------- Перенаправленное сообщение --------
>>>>> Тема: nvidia-driver build error (last ports, FreeBSD-HEAD)
>>>>> Дата: Tue, 21 Aug 2018 16:41:42 +0700
>>>>> От: Alex V. Petrov<alexvpetrov at gmail.com>
>>>>> Кому: FreeBSD Ports<freebsd-ports at freebsd.org>
>>>> Should be fixed as of r477761.
>>>>
>>>> ./danfe
>> It's not fixed, seems to error elsewhere now:
>>
>> context: 12.0-ALPHA1 #0 r337886 / ports r477782 / empty /etc/make.conf
>>
>> This is a bare metal installation.
>>
>> root at desktop:/usr/ports/x11/nvidia-driver# make distclean && make
>> clean && make MAKE_JOBS_UNSAFE=yes
>>
>> [...]
>>
>> cc  -O2 -pipe -fno-strict-aliasing -DNV_VERSION_STRING=\"390.77\"
>> -D__KERNEL__ -DNVRM -Wno-unused-function -Wuninitialized -O2
>> -fno-strict-aliasing -mno-red-zone -mcmodel=kernel -Wno-sign-compare
>> -Wno-format-extra-args -UDEBUG -U_DEBUG -DNDEBUG -Werror=undef 
>> -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I. -I../common/inc -I.
>> -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common 
>> -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer   -MD 
>> -MF.depend.nvidia_subr.o -MTnvidia_subr.o -mcmodel=kernel
>> -mno-red-zone -mno-mmx -mno-sse -msoft-float 
>> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv
>> -fstack-protector -Wall -Wredundant-decls -Wnested-externs
>> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual
>> -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__
>> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas
>> -Wno-error-tautological-compare -Wno-error-empty-body
>> -Wno-error-parentheses-equality -Wno-error-unused-function
>> -Wno-error-pointer-sign -Wno-error-shift-negative-value
>> -Wno-address-of-packed-member  -mno-aes -mno-avx  -std=iso9899:1999 -c
>> nvidia_subr.c -o nvidia_subr.o
>> nvidia_subr.c:1131:41: error: too many arguments to function call,
>> expected 7, have 8
>>             sc->dma_mask, PAGE_SIZE, 0, attr);
>>                                         ^~~~
>> /usr/src/sys/vm/vm_extern.h:61:1: note: 'kmem_alloc_contig' declared here
>> vm_offset_t kmem_alloc_contig(vm_size_t size, int flags,
>> ^
>> nvidia_subr.c:1269:45: error: too many arguments to function call,
>> expected 7, have 8
>>                 sc->dma_mask, PAGE_SIZE, 0, attr);
>>                                             ^~~~
>> /usr/src/sys/vm/vm_extern.h:61:1: note: 'kmem_alloc_contig' declared here
>> vm_offset_t kmem_alloc_contig(vm_size_t size, int flags,
>> ^
>> 2 errors generated.
>> *** Error code 1
>>
>> Stop.
>> make[4]: stopped in
>> /usr/ports/x11/nvidia-driver/work/NVIDIA-FreeBSD-x86_64-390.77/src/nvidia
>> *** Error code 1
>>
>> Stop.
>> make[3]: stopped in
>> /usr/ports/x11/nvidia-driver/work/NVIDIA-FreeBSD-x86_64-390.77/src
>> *** Error code 1
>>
>> Stop.
>> make[2]: stopped in
>> /usr/ports/x11/nvidia-driver/work/NVIDIA-FreeBSD-x86_64-390.77
>> *** Error code 1
>>
>> Stop.
>> make[1]: stopped in /usr/ports/x11/nvidia-driver
>> *** Error code 1
>>
>> Stop.
>> make: stopped in /usr/ports/x11/nvidia-driver
>> root at desktop:/usr/ports/x11/nvidia-driver#
>>
> All of kmem_alloc_attr(), kmem_alloc_contig(), and kmem_malloc() should
> have their first parameter, typically kernel_arena, but sometimes
> kmem_arena, removed in FreeBSD 12.
>
> There is still one more pending change to kmem_free() that has not hit
> HEAD yet.  That change will be the last.

The last change in this series has been committed to HEAD.  With that
change, you will want to remove the first argument, which should be an
arena pointer,  from kmem_free() calls. 

Alan