mount_smbfs gives error when stored crypted pw is used

[Matthias Apitz]

El día miércoles, junio 07, 2017 a las 02:35:31p. m. +0200, Matthias Apitz escribió:

> I have located the bug in /usr/src/contrib/smbfs/lib/smb/subr.c 
> 
> The printf(3C) calls have been added for debugging; the bug is the
> addition of 13 after crypting every char which let the mask used in ^ operation
> exceeding 256, i.e. more than one byte, if the string to be crypted is long
> enough. The two lines added:
> 
>                 if (pos > 256)
>                     pos = pos-256;
> 
> fixes this issue and the crypting/decypting works fine; see below;
> 
> I'll later file a PR and propose the patch;

The PR was already made in 2009: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=132302
has a patch attached (nearly the same solution as I have found), but was
never ci'ed :-(

	matthias


-- 
Matthias Apitz, ✉ guru at unixarea.de, ⌂ http://www.unixarea.de/  ☎ +49-176-38902045
Public GnuPG key: http://www.unixarea.de/key.pub
8. Mai 1945: Wer nicht feiert hat den Krieg verloren.
8 de mayo de 1945: Quien no festeja perdió la Guerra.
May 8, 1945: Who does not celebrate lost the War.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20170607/4c9ef1da/attachment.sig>