resolvconf needs @RESTARTCMD@ to be replaced after r303062

[Pedro Giffuni]

(CC'ing Glen for review, since he was the last to touch that file and
may know better).

Hi Guy;


On 07/30/16 17:37, Guy Yur wrote:
> Hi,
>
> openresolv 3.8.1 added RESTARTCMD=@RESTARTCMD@ in
> contrib/openresolv/resolvconf.in.
> It is not replaced by the sed expressions in sbin/resolvconf/Makefile.
>
> Error seen is "eval: @RESTARTCMD@: not found".
>
> Current @RESTARTCMD \(.*\)@ sed expression needs to be kept for
> pdns_recursor.in and a new expression added to replace @RESTARTCMD at .
>

I see, you mean here:

https://svnweb.freebsd.org/base/head/sbin/resolvconf/Makefile?revision=298107&view=markup#l32

> The following worked for me:
> RESTARTCMD_=    "/usr/sbin/service \\$$1 onestatus >/dev/null 2>\&1
> \&\& /usr/sbin/service \\$$1 restart"
>
> sed ... \
>   ... \
>   -e 's:@RESTARTCMD@:${RESTARTCMD_}:g' \
>   ...

And perhaps something like the attached patch (is the underscore
a typo?).

I don't see the error message though. so I need some confirmation that
this fixes the issue.

Pedro.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: resolvconf-restartcmd.diff
Type: text/x-patch
Size: 454 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20160730/d0838d5c/attachment.bin>