Oversight in /etc/defaults/rc.conf

[Allan Jude]

On 2016-07-12 08:27, Glen Barber wrote:
> On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote:
>> I just upgraded my main machine to 11-STABLE.  Things are mostly working
>> fine -- however I did notice that the new iovctl rc script is apparently
>> enabled by default.  That seems like a trivial omission:
>>
>> Index: etc/defaults/rc.conf
>> ===================================================================
>> --- etc/defaults/rc.conf	(revision 302482)
>> +++ etc/defaults/rc.conf	(working copy)
>> @@ -695,6 +695,7 @@
>>  rctl_enable="YES"		# Load rctl(8) rules on boot
>>  rctl_rules="/etc/rctl.conf"	# rctl(8) ruleset. See rctl.conf(5).
>>
>> +iovctl_enable="NO"
>>  iovctl_files=""		# Config files for iovctl(8)
>>
>>  ##############################################################
>>
> 
> I'm not sure I understand.  Is there a functional and/or performance
> impact with it enabled by default?  (Note, I don't disable it in my
> rc.conf, and there is no /dev/iov/* on my system.)
> 
> Glen
> 

If the service should be on by default, then it should have
iovctl_enable="YES" in etc/defaults/rc.conf

One way or the other, a default should be set.

-- 
Allan Jude