thread-unsafety problems as spl*() ones are NOP

Warner Losh imp at bsdimp.com
Sun Jan 31 04:56:25 UTC 2016


> On Jan 30, 2016, at 9:37 PM, mokhi <mokhi64 at gmail.com> wrote:
> 
> @imp So you think I should start to put locks there and see what happens? :)

I’d advocate a deeper understanding of the code. splXXX() is for code path
exclusion. Locks are for data protection. These are subtly different concepts
and may cause issues when you try to just blindly replace the splXXX with
a lock. You can start there, but you’ll still need to do code-path analysis to
see what the locks wind up protecting, and then see if there’s any access
to it outside of locked paths.

Warner

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20160130/2f812242/attachment.sig>


More information about the freebsd-current mailing list