mtree patch for WITHOUT_LPR
NGie Cooper
yaneurabeya at gmail.com
Sat Nov 7 20:16:21 UTC 2015
> On Nov 7, 2015, at 10:56, Dmitry Morozovsky <marck at rinet.ru> wrote:
>
> On Sat, 7 Nov 2015, Bryan Drewery wrote:
>
>>>>> +/set type=dir uname=root gname=wheel mode=0755
>>>>> +.
>>>>> + include
>>>>> + atf-c
>>>>> + ..
>>>>> + atf-c++
>>>>> + ..
>>>>
>>>> This diff is incorrect.
>>>
>>> Yes, as Brian noted, this is completely orthogonal.
>>>
>>>> There are a lot of other things that need to be fixed if we go down this
>>>> path. Do you have a plan or idea of what all needs to be fixed?
>>>
>>> Well, I do not like the idea of tons of micro mtree files; OTOH, it would be
>>> great if we could avoid creation of unnecessary directories/files when
>>> particular WITHOU_* know is set.
>>
>> Another way of looking at this problem is that if a directory is in the
>> dist mtrees, it should not be listed as an OLD_DIRS.
>
> ... and this principle I do like much more, yes. It's no harm to have an empty
> subtree.
Agreed to the above. Some people disagree (and bugs have been filed for it), but as long as there’s a uniform consensus, I think we’ll be fine.
Thanks,
-NGie
More information about the freebsd-current
mailing list