Apple Trackpad driver
黄文辉@Gmail
huanghwh at gmail.com
Fri Jan 31 23:45:11 UTC 2014
Hi Hans,
Yes, I wrote wsp base on atp(4) and bcm5974.c from Linux. Of course we can add a notice about that. Table and some structure bt_data, tp_finger from Linux, I only wrote wsp_intr_callback base on usbdump, all other part should be belong to Hans.
Cheers,
Huang Wen Hui
> 在 2014年2月1日,6:49,Hans Petter Selasky <hps at bitfrost.no> 写道:
>
>> On 01/31/14 21:30, Danilo E. Gondolfo wrote:
>>> On 01/31/14 05:16, Hans Petter Selasky wrote:
>>>> On 01/31/14 02:46, Huang Wen Hui wrote:
>>>> Hi Hans,
>>>>
>>>> pos_x[] is not non-inialized, it may be previous pos_x, it is still
>>>> ok for
>>>> getting dx.
>>>> "n" var is trying to reduce "untouch" sensor data for post
>>>> proccessing. I
>>>> attach a new patch
>>>> may be more clear, also fixed unexpected movement when button status or
>>>> ntouch changing.
>>>>
>>>> Cheers,
>>>>
>>>> Huang Wen Hui
>>>
>>> Hi,
>>>
>>> http://svnweb.freebsd.org/changeset/base/261315
>>>
>>> --HPS
>>
>> Good work!
>>
>> I noticed that your driver is based on the Linux driver [1] and some
>> pieces of code are copied, are you sure that we won't have any problems
>> with license?
>>
>> These changes can be (should be) merged in the driver atp(4), no?
>>
>> Danilo.
>>
>>
>> [1] - http://lxr.free-electrons.com/source/drivers/input/mouse/bcm5974.c
>
> Hi,
>
> It looks to me like some tables have been copied. We probably should add a notice about that. The rest of the code looks OK to me.
>
> Huang, any comments?
>
> --HPS
>
More information about the freebsd-current
mailing list