RFC: swapon(8) vnode-backed md and gbde/geli encryption support

Hiroki Sato hrs at FreeBSD.org
Sun Jun 23 18:26:11 UTC 2013


Scot Hetzel <swhetzel at gmail.com> wrote
  in <CACdU+f-OuPNckG+MJgfDopbT43xMrLy19LmEzLqgZ_XU9yYX7Q at mail.gmail.com>:

sw> The only thing I see is that you are hard coding the geli_swap_flags
sw> (i.e. -e aes -l 256 -s 4096 -d) into swapon.  It would be better to
sw> have swapon read the /etc/fstab file to get these values:
sw>
sw> /dev/ada1p2.eli        none    swap
sw> sw,ealgo=aes,keylen=256,sectorsize=4096              0 0
sw> /dev/ada2p2.eli        none    swap    sw              0 0
sw>
sw> What you could do is that if no options are specified in the swap
sw> file, swapon would then use default values for ealgo=aes, keylen=256
sw> and sectorsize=4096.

 Thank you for your feedback.  These options are implemented in the
 attached patch.

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: swap_20130624-1.diff
Type: text/x-patch
Size: 22783 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20130624/da7cc0b0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20130624/da7cc0b0/attachment.sig>


More information about the freebsd-current mailing list