(follow-up) "Stale NFS file handle" for NFS exported UFS from r252435

Pedro Giffuni pfg at FreeBSD.org
Wed Jul 10 16:40:31 UTC 2013


On 10.07.2013 10:16, Claude Buisson wrote:
> On 07/10/2013 17:05, Pedro Giffuni wrote:
>> Hello guys;
>>
>> Thank for finding this, however ...
>>
>
> <snip>
>
>>
>> While I understand this change caused the issue and I am willing to
>> revert it,
>> I think the problem is actually in NFS. At least ext2/3/4 and fuse (so I
>> presume
>> glusterfs) have unsigned i_gen.
>>
>
> I have the same thinking (and was rather astonished by the success of 
> my try at
> reverting it): there is something somewhere in the NFS code which have 
> not been
> synced with the UFS change.
>
> It is the reason I CC'ed rmacklem@
>
>> Pedro.
>>
>
> Claude Buisson
>
I found a missing type change. Can you try the attached patch?

Cheers,

Pedro.
-------------- next part --------------
Index: sys/ufs/ufs/inode.h
===================================================================
--- sys/ufs/ufs/inode.h	(revision 253159)
+++ sys/ufs/ufs/inode.h	(working copy)
@@ -180,7 +180,7 @@
 	u_int16_t ufid_len;	/* Length of structure. */
 	u_int16_t ufid_pad;	/* Force 32-bit alignment. */
 	uint32_t  ufid_ino;	/* File number (ino). */
-	int32_t	  ufid_gen;	/* Generation number. */
+	uint32_t  ufid_gen;	/* Generation number. */
 };
 #endif /* _KERNEL */
 


More information about the freebsd-current mailing list