[PATCH] nvmecontrol breaks world
Steve Kargl
sgk at troutmask.apl.washington.edu
Tue Jul 2 23:23:12 UTC 2013
On Tue, Jul 02, 2013 at 10:30:53PM +0200, Ed Schouten wrote:
> 2013/7/2 Steve Kargl <sgk at troutmask.apl.washington.edu>:
> > Could someone (this could even be me, but need approval) please
> > fix nvmecontrol?
>
> off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?
> Also, the call of malloc(sb.st_size) is not really safe...
>
jimharris committed the patch. I suspect that this is intel
code, which needs to be portable to other OS's. Hopefully,
he fixes the build soon.
--
Steve
More information about the freebsd-current
mailing list