[PATCH] nvmecontrol breaks world

Dimitry Andric dim at FreeBSD.org
Tue Jul 2 20:37:39 UTC 2013


On Jul 2, 2013, at 22:30, Ed Schouten <ed at 80386.nl> wrote:
> 2013/7/2 Steve Kargl <sgk at troutmask.apl.washington.edu>:
>> Could someone (this could even be me, but need approval) please
>> fix nvmecontrol?
> 
> off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?

Yes, that is what Bruce has suggested for off_t many times in the past. :-)


> Also, the call of malloc(sb.st_size) is not really safe...

Sure, but that does not break buildworld (for gcc users, I assume? the tinderboxes are all green).

-Dimitry



More information about the freebsd-current mailing list