panic after r244584
Justin T. Gibbs
gibbs at freebsd.org
Wed Jan 23 21:29:28 UTC 2013
On Jan 23, 2013, at 1:39 PM, Alexander Motin <mav at FreeBSD.org> wrote:
> On 23.01.2013 21:51, Jaakko Heinonen wrote:
>> On 2013-01-23, Vitalij Satanivskij wrote:
>>> VS> Jaakko Heinonen wrote:
>>> VS> JH> > I see two possible solutions for the problem.
>>> VS> JH> >
>>> VS> JH> > 1) Replace non-printable, space and '/' characters for example with '_'.
>>> VS> JH> > '/' should be replaced anyway.
>>> VS> JH> >
>>> VS> JH> > 2) Apply the patches in
>>> VS> JH> > http://lists.freebsd.org/pipermail/svn-src-all/2013-January/063661.html
>>> VS> JH> > to allow spaces again. I haven't committed the patches because I
>>> VS> JH> > think that there isn't full consensus that it's right thing to do and
>>> VS> JH> > also I personally prefer not to have spaces in device names.
>>> VS> JH>
>>> VS> JH> Here's a patch to implement 1:
>>> VS> JH>
>>> VS> JH> http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff
>>> VS>
>>> VS> Ok that patch work's too.
>>>
>>> Is there any chance, that one of this patches will be merged to head?
>>
>> Yes.
>>
>> Alexander and Justin: what do you think about this patch?
>>
>> http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff
>
> It is fine for me, or at least better then panic. But that is Justin's
> code, so he should know better.
It's fine.
--
Justin
More information about the freebsd-current
mailing list