panic after r244584

[Alexander Motin]

On 18.01.2013 15:19, Jaakko Heinonen wrote:
> On 2013-01-18, Alexander Motin wrote:
>>> AM> > V>  panic: make_dev_alias_v: bad si_name (error=22 si_name=enc at n5003048000bab37d/tpe0/slot at 1/elmdesc at Slot 01/pass7)
> 
>>> AM> The panic is triggered by the check added by the recent r244584 change.
>>> AM> The space in device name came from the enclosure device, and I guess it
>>> AM> may be quite often situation. Using human readable name supposed to help
>>> AM> system administrators, but with spaces banned that may be a problem.
>>>
>>> That's was not created by human, it was generated (I think so) by system. 
>>
>> These strings are flashed into enclosure firmware by manufacturer.
> 
> You can't rely on that any string can be safely used as a device name
> even if spaces were allowed. Consider for example duplicate names and
> "../".
> 
> Where these names are generated? The original report didn't contain a
> backtrace.

At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are
impossible there, as previous name components are unique. Special
characters haven't yet seen, but I think theoretically possible.
Interesting what Solaris does in such cases, mangles them somehow or
removes completely?

-- 
Alexander Motin