panic after r244584

[Alexander Motin]

On 18.01.2013 13:39, Vitalij Satanivskij wrote:
> Alexander Motin wrote:
> AM> On 18.01.2013 11:44, Gleb Smirnoff wrote:
> AM> > On Fri, Jan 18, 2013 at 09:36:00AM +0200, Vitalij Satanivskij wrote:
> AM> > V> After upgrading server from old hardware/software to freebsd current (## SVN ## Exported commit - http://svnweb.freebsd.org/changeset/base/245479),
> AM> > V> system hung's with message - 
> AM> > V>  panic: make_dev_alias_v: bad si_name (error=22 si_name=enc at n5003048000bab37d/tpe0/slot at 1/elmdesc at Slot 01/pass7)
> AM> > 
> AM> > EINVAL (22) is caused by space character in the si_name:
> AM> > 
> AM> > si_name=enc at n5003048000bab37d/tpe0/slot at 1/elmdesc at Slot 01/pass7
> AM> > 
> AM> > I think Alexander (in Cc) has idea on why did that happen and how
> AM> > should that be fixed.
> AM> 
> AM> The panic is triggered by the check added by the recent r244584 change.
> AM> The space in device name came from the enclosure device, and I guess it
> AM> may be quite often situation. Using human readable name supposed to help
> AM> system administrators, but with spaces banned that may be a problem.
> 
> That's was not created by human, it was generated (I think so) by system. 

These strings are flashed into enclosure firmware by manufacturer.

> May be problem not in r244584 at all but in incorect generation of the si_name ? 

May be. But before r244584 it didn't cause panics and most of people
were happy, except devctl consumers, who can't parse these events properly.

> More info 
> 
> drive (actualy drives, all 36 have same problem) inserted in backplane on supermicro chasis with "LSI CORP SAS2X36 0417" on board.
> 
> All of them attached to lsi sas 9211-4i controler in HBA mode.

-- 
Alexander Motin